[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715805#comment-14715805
]
Ewen Cheslack-Postava commented on KAFKA-2389:
----------------------------------------------
I'd also say that just because the Zookeeper API has it doesn't make it good
API design... I don't know about other people, but I raised the concern about
naming again in the code review because I actually did get confused about what
the semantics of each method signature was.
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
