[
https://issues.apache.org/jira/browse/KAFKA-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731295#comment-14731295
]
Ismael Juma commented on KAFKA-2513:
------------------------------------
[~ewencp], by your argument, checkstyle shouldn't prevent one from running the
unit/integration tests either (and it does). It's also worth recognising that
this is a trade-off and the current approach does waste people's time in other
situations. Personally I find it quite annoying to have a number of checkstyle
failures when I think the code is in a good state and it's time to run the
tests. I'd much prefer to get the failures incrementally as I am compiling so
that I can fix it as I write the code (and I am near the code).
Anyway, I don't think there is a clearly superior way, it depends a lot on the
workflow and it's good to understand the different ones. I have a few ideas of
how to make things better, but that's not at the top of my priority queue at
the moment. Hopefully not too far into the future.
> Checkstyle is not executed until gradle's tests phase
> -----------------------------------------------------
>
> Key: KAFKA-2513
> URL: https://issues.apache.org/jira/browse/KAFKA-2513
> Project: Kafka
> Issue Type: Bug
> Reporter: Ashish K Singh
> Assignee: Ashish K Singh
> Priority: Minor
>
> Checkstyle is added as a dependency to test and until someone runs test they
> won't capture checkstyle issues. To me code style is more suited along with
> compile than tests. This was also brought up on KAFKA-1893. May be we should
> make checkstyle a dependency of jar, instead of test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
