[ 
https://issues.apache.org/jira/browse/KAFKA-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731401#comment-14731401
 ] 

ASF GitHub Bot commented on KAFKA-2440:
---------------------------------------

GitHub user ijuma reopened a pull request:

    https://github.com/apache/kafka/pull/194

    KAFKA-2440; Use `NetworkClient` instead of `SimpleConsumer` to fetch data 
from replica

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka 
kafka-2440-use-network-client-in-fetcher

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #194
    
----
commit 6f34f70d5ac9c320cc8655c0de26aeee6cb2b300
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2015-09-04T20:42:41Z

    Use `NetworkClient` in `ReplicaFetcherThread`
    
    `ConsumerFetcherThread` still uses `SimpleConsumer`.

commit 57a4c0a691167c503d8a51e3bb604f7b212c4890
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2015-09-04T20:43:30Z

    Call `metadataUpdater.maybeHandleDisconnection` from `NetworkClient.close()`

----


> Use `NetworkClient` instead of `SimpleConsumer` to fetch data from replica
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-2440
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2440
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>            Priority: Blocker
>             Fix For: 0.8.3
>
>
> This is necessary for SSL/TLS support for inter-broker communication as 
> `SimpleConsumer` will not be updated to support SSL/TLS.
> As explained by [~junrao] in KAFKA-2411: we need to be a bit careful since 
> the follower fetcher thread doesn't need to refresh metadata itself. Instead, 
> the information about the leader is propagated from the controller.
> This work was originally described in KAFKA-2411, which was then updated to 
> be more narrowly focused on replacing `BlockingChannel` with `Selector`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to