[ https://issues.apache.org/jira/browse/KAFKA-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737234#comment-14737234 ]
ASF GitHub Bot commented on KAFKA-2512: --------------------------------------- GitHub user becketqin opened a pull request: https://github.com/apache/kafka/pull/200 KAFKA-2512: Add version check to broker and clients. You can merge this pull request into a Git repository by running: $ git pull https://github.com/becketqin/kafka KAFKA-2512 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #200 ---- commit 486476bd7e270b5f32e35df98d9d3921a665879b Author: Jiangjie Qin <becket....@gmail.com> Date: 2015-09-08T14:47:56Z KAFKA-2512: Add version check to broker and clients. ---- > Add version and magic byte verification on broker and clients. > -------------------------------------------------------------- > > Key: KAFKA-2512 > URL: https://issues.apache.org/jira/browse/KAFKA-2512 > Project: Kafka > Issue Type: Bug > Reporter: Jiangjie Qin > Assignee: Jiangjie Qin > > Both new and old consumer do not verify the magic byte of a message when it > consumes a message. This is needed for protocol upgrade so the consumer can > provide correct information to user. Same check is needed on broker side and > well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)