> On Sept. 10, 2015, 6:19 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java, line > > 137 > > <https://reviews.apache.org/r/36858/diff/9/?file=1066895#file1066895line137> > > > > Out of curiosity, why are we using `LinkedList` here? Generally > > `ArrayList` is a better default, but maybe there's a good reason to deviate > > in this case. > > Mayuresh Gharat wrote: > LinkedList add method gives O(1) performance while ArrayList gives O(n) > in worst case. Since we are just adding and not doing random accesses > LinkedList would be better in this case.
This analysis is a bit incomplete: ArrayList has amortised O(1) append and simply O(1) append if you know the expected size. Furthermore, it is much more cache-friendly and memory efficient than LinkedList. These factors mean that it's almost always a better data structure than LinkedList in modern hardware. - Ismael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/#review98438 ----------------------------------------------------------- On Sept. 11, 2015, 4:39 a.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36858/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 4:39 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2120 > https://issues.apache.org/jira/browse/KAFKA-2120 > > > Repository: kafka > > > Description > ------- > > Solved compile error > > > Addressed Jason's comments for Kip-19 > > > Addressed Jun's comments > > > Addressed Jason's comments about the default values for requestTimeout > > > checkpoint > > > Addressed Joel's concerns. Also tried to include Jun's feedback. > > > Fixed a minor comment > > > Solved unittest issue > > > Addressed Jun's comments regarding NetworkClient > > > Addressed Jun's comments about disconnect() in Selector > > > changed logging level to debug > > > Addressed Joels comments to break out early from the loop while aborting > expired batches > > > Addressed Jun's comments > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/ClientRequest.java > dc8f0f115bcda893c95d17c0a57be8d14518d034 > clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java > 7d24c6f5dd2b63b96584f3aa8922a1d048dc1ae4 > clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java > 15d00d4e484bb5d51a9ae6857ed6e024a2cc1820 > clients/src/main/java/org/apache/kafka/clients/KafkaClient.java > f46c0d9b5eb73887c62a0e09c96e9d8c964c709d > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java > 049b22eadd5496b70dfcfd9d821f67c62c68a052 > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java > b9a2d4e2bc565f0ee72b27791afe5c894af262f1 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 19ef6ebead3dc97d4912985e35b6b8d17503cb0e > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java > 9517d9d0cd480d5ba1d12f1fde7963e60528d2f8 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 804d569498396d431880641041fc9292076452cb > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > 06f00a99a73a288df9afa8c1d4abe3580fa968a6 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java > 4cb1e50d6c4ed55241aeaef1d3af09def5274103 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > a152bd7697dca55609a9ec4cfe0a82c10595fbc3 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java > 06182db1c3a5da85648199b4c0c98b80ea7c6c0c > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > d2e64f7cd8bf56e433a210905b2874f71eee9ea0 > clients/src/main/java/org/apache/kafka/common/network/Selectable.java > 70e74bd6aa629c430b2850ca40c97df0b16e5d75 > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 4aa5cbb86ce6e1bf8f6769147ee2a6452c855c74 > clients/src/test/java/org/apache/kafka/clients/MockClient.java > e5815f56bdf8e2d980f2bc36b831ed234c0ac781 > clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java > 69c93c3adf674b1640534c3d7410fcaafaf2232c > > clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java > 2c693824fa53db1e38766b8c66a0ef42ef9d0f3a > > clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java > 5b2e4ffaeab7127648db608c179703b27b577414 > > clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java > aa44991777a855f4b7f4f7bf17107c69393ff8ff > clients/src/test/java/org/apache/kafka/common/network/SSLSelectorTest.java > df1205c935bee9a30a50816dbade64d6014b1ef2 > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > 3a684d98b05cadfb25c6f7f9a038ef1f6697edbf > clients/src/test/java/org/apache/kafka/test/MockSelector.java > f83fd9b794a3bd191121a22bcb40fd6ec31d83b5 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > da1cff07f7f76dcfa5a805718febcccd4ed5f578 > core/src/main/scala/kafka/server/KafkaConfig.scala > 1e8b2331486ffe55bfcc0919e48e12aad23b7d3c > core/src/main/scala/kafka/server/KafkaServer.scala > 30406ce809caaac56aca1f30c235b35962d55a50 > core/src/main/scala/kafka/tools/ProducerPerformance.scala > 46a68e97b8bcc8821f21e4220ce9b3acedc5dafe > core/src/main/scala/kafka/utils/NetworkClientBlockingOps.scala > ad10721de844725f27a116611209992cea61b088 > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 1198df02ddd7727269e84a751ba99520f6d5584a > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 5b4f2db4607ae6d17696c1140f1a771ce75c80e0 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 09b8444c2add87f0f70dbb182e892977a6b5c243 > > Diff: https://reviews.apache.org/r/36858/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
