[
https://issues.apache.org/jira/browse/KAFKA-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906638#comment-14906638
]
ASF GitHub Bot commented on KAFKA-2548:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/238
KAFKA-2548; kafka-merge-pr tool fails to update JIRA with fix version
0.9.0.0
Simplified the logic to choose the default fix version. We just hardcode
it for `trunk` and try to compute it based on the branch name for the
rest.
Removed logic that tries to handle forked release branches as it
seems to be specific to how the Spark project handles their JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-2548-merge-pr-tool-4-segment-fix-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit a2e6787f923fffb092d7f4c880923c501d2a9b9f
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2015-09-24T16:43:14Z
Don't fail on fix versions with 4 segments
Simplified the logic to choose the default fix version. We just hardcode
it for `trunk` and try to compute it based on the branch name for the
rest.
Removed logic that tries to handle forked release branches as it
seems to be specific to how the Spark project handles their JIRA.
----
> kafka-merge-pr tool fails to update JIRA with fix version 0.9.0.0
> -----------------------------------------------------------------
>
> Key: KAFKA-2548
> URL: https://issues.apache.org/jira/browse/KAFKA-2548
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Ismael Juma
> Labels: newbie
> Fix For: 0.9.0.0
>
>
> Trying to update JIRA where the fix version is set to '0.9.0.0', I get the
> following error:
> {code}
> Traceback (most recent call last):
> File "kafka-merge-pr.py", line 474, in <module>
> main()
> File "kafka-merge-pr.py", line 460, in main
> resolve_jira_issues(commit_title, merged_refs, jira_comment)
> File "kafka-merge-pr.py", line 317, in resolve_jira_issues
> resolve_jira_issue(merge_branches, comment, jira_id)
> File "kafka-merge-pr.py", line 285, in resolve_jira_issue
> (major, minor, patch) = v.split(".")
> ValueError: too many values to unpack
> {code}
> We need to handle 3 and 4 part versions (x.y.z and x.y.z.w)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
