[
https://issues.apache.org/jira/browse/KAFKA-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943669#comment-14943669
]
Ewen Cheslack-Postava commented on KAFKA-2604:
----------------------------------------------
[~ijuma] Changed the reviewer to a committer since I've reviewed the patch.
[~guozhang] this is small and largely cleanup so should be a quick review.
> Remove `completeAll` and improve timeout passed to `Selector.poll` from
> `NetworkClient.poll`
> --------------------------------------------------------------------------------------------
>
> Key: KAFKA-2604
> URL: https://issues.apache.org/jira/browse/KAFKA-2604
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 0.9.0.0
>
>
> Now that KAFKA-2120 has been merged, we can improve a few things:
> 1. Remove `NetworkClient.completeAll`
> 2. Call `Selector.poll` with a timeout that is the minimum of timeout,
> metadata timeout and request timeout
> 3. Disallow `Selector.poll(-1)` as it's not used and not something that we
> want generally (and one can always use `Selector.poll(Integer.MAX_VALUE)` if
> one really wants it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
