[
https://issues.apache.org/jira/browse/KAFKA-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945849#comment-14945849
]
Jiangjie Qin commented on KAFKA-2615:
-------------------------------------
[~hachikuji] I see. Yes, that is an issue. It actually might impact the request
timeout settings. Although I kind of like the unified logic clock, we may have
to change it.
One alternative could be let the selector.poll() return the time elapsed
instead of void. And use the do something like now += selector.poll(timeout).
This might be a little hacky but less time skew sensitive because we keep the
logic clock.
> Poll() method is broken wrt time
> --------------------------------
>
> Key: KAFKA-2615
> URL: https://issues.apache.org/jira/browse/KAFKA-2615
> Project: Kafka
> Issue Type: Bug
> Components: clients, consumer, producer
> Affects Versions: 0.8.2.1
> Reporter: Eno Thereska
> Assignee: Eno Thereska
>
> Initially reported by [~ewencp] and discussed with [~hachikuji]. In
> NetworkClient.java, the poll() method receives as input a "now" parameter,
> does a whole bunch of work (e.g., selector.poll()) and then keeps using "now"
> in all the subsequent method calls.
> Passing Time everywhere instead of "now" is a potential fix, but might be
> expensive since it's a new system call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
