[
https://issues.apache.org/jira/browse/KAFKA-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947389#comment-14947389
]
ASF GitHub Bot commented on KAFKA-2620:
---------------------------------------
GitHub user granthenke opened a pull request:
https://github.com/apache/kafka/pull/284
KAFKA-2620: Introduce Scalariform
This is a WIP. There will likely need to be discussion around a rule set we
want to use and if we actually want to include this in the build. This could
also be used as a one time rebase.
This commit does not include the actual formatting changes. To see what
effect the patch has run
```gradle formatScala```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/granthenke/kafka scalariform
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #284
----
commit dd08673ef491184912068ee3595869433403bcd1
Author: Grant Henke <granthe...@gmail.com>
Date: 2015-10-07T19:04:20Z
KAFKA-2620: Introduce Scalariform
----
> Introduce Scalariform
> ---------------------
>
> Key: KAFKA-2620
> URL: https://issues.apache.org/jira/browse/KAFKA-2620
> Project: Kafka
> Issue Type: Bug
> Components: build
> Reporter: Grant Henke
> Assignee: Grant Henke
>
> Many of our reviews include nit comments related to Scala style. Adding
> [Scalariform|https://github.com/daniel-trinh/scalariform] allows us to
> reformat the code based on configurable standards at build time, ensuring
> uniform readability and a short review/commit cycle.
> I expect this will have some discussion around the rules we would like to
> include, and if we actually want to adopt this. I will submit a sample patch
> to start the discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
