[
https://issues.apache.org/jira/browse/KAFKA-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eno Thereska updated KAFKA-2615:
--------------------------------
Labels: patch (was: )
Reviewer: Guozhang Wang
Fix Version/s: 0.8.2.1
Status: Patch Available (was: Open)
GitHub user enothereska opened a pull request:
https://github.com/apache/kafka/pull/290
KAFKA-2459: connection backoff, timeouts and retries
This fix applies to three JIRAs, since they are all connected.
KAFKA-2459Connection backoff/blackout period should start when a connection is
disconnected, not when the connection attempt was initiated
Backoff when connection is disconnected
KAFKA-2615Poll() method is broken wrt time
Added Time through the NetworkClient API. Minimal change.
KAFKA-1843Metadata fetch/refresh in new producer should handle all node
connection states gracefully
I’ve partially addressed this for a specific failure case in the JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enothereska/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #290
> Poll() method is broken wrt time
> --------------------------------
>
> Key: KAFKA-2615
> URL: https://issues.apache.org/jira/browse/KAFKA-2615
> Project: Kafka
> Issue Type: Bug
> Components: clients, consumer, producer
> Affects Versions: 0.8.2.1
> Reporter: Eno Thereska
> Assignee: Eno Thereska
> Labels: patch
> Fix For: 0.8.2.1
>
>
> Initially reported by [~ewencp] and discussed with [~hachikuji]. In
> NetworkClient.java, the poll() method receives as input a "now" parameter,
> does a whole bunch of work (e.g., selector.poll()) and then keeps using "now"
> in all the subsequent method calls.
> Passing Time everywhere instead of "now" is a potential fix, but might be
> expensive since it's a new system call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
