[ 
https://issues.apache.org/jira/browse/KAFKA-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956115#comment-14956115
 ] 

ASF GitHub Bot commented on KAFKA-2632:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/295


> Move fetchable check from fetchedRecords to fetch response handler
> ------------------------------------------------------------------
>
>                 Key: KAFKA-2632
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2632
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: consumer
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>             Fix For: 0.9.0.0
>
>
> Since we check if the partition is fetchable or not in fetchedRecords(), 
> there is a bug when the partition is paused during there is in-flight fetch 
> request, it will not be ignored in fetch response handler but after that, in 
> fetchedRecords(), causing the fetcher to update the fetched position already; 
> later no fetch requests will ever be sent to the broker for this partition 
> since consumed != fetched.
> The proposed fix is to move this check from fetchedRecords to 
> handleFetchResponse in Fetcher.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to