[ 
https://issues.apache.org/jira/browse/KAFKA-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964360#comment-14964360
 ] 

Gwen Shapira commented on KAFKA-2671:
-------------------------------------

In second look, metrics are currently handled in both KafkaServer and the Kafka 
singleton. 
This looks wrong. 

Perhaps you can figure out why and see if we can safely move all metrics 
handling inside KafkaServer?

After that, your wrapper will just need to handle the shutdownhook and call 
KafkaServer, which sounds reasonable to me. 


> Enable starting Kafka server with a Properties object
> -----------------------------------------------------
>
>                 Key: KAFKA-2671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2671
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>            Reporter: Ashish K Singh
>            Assignee: Ashish K Singh
>
> Kafka, as of now, can only be started with a properties file and override 
> params. It makes life easier for management applications to be able to start 
> Kafka with a properties object programatically.
> The changes required to enable this are minimal, just a tad bit of 
> refactoring of kafka.Kafka. The changes must maintain current behavior intact.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to