[ 
https://issues.apache.org/jira/browse/KAFKA-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964788#comment-14964788
 ] 

Ismael Juma edited comment on KAFKA-2472 at 10/20/15 8:27 AM:
--------------------------------------------------------------

[~junrao], the reason why we have the warnings is that we are passing a 
Map<String, ?> to the various `configure` methods and we do that by calling 
`AbstractConfig.values()`. This means that the usage of the parameters is never 
recorded and we also have to cast instead of using the nicer getString, getInt, 
etc. methods. And we also have `KafkaConfig.channelConfigs` where we must 
remember to add the relevant configs (which is error-prone).

Is there a reason why the `configure` methods can't accept an `AbstractConfig` 
instead of `Map<String, ?>`?


was (Author: ijuma):
[~junrao], the reason why we have the warnings is that we are passing a 
Map<String, ?> to the various `configure` methods and we do that by calling 
`AbstractConfig.values()`. This means that the usage of the parameters is never 
recorded and we also have to cast instead of using the nicer `get{String, Int, 
...}` methods. And we also have `KafkaConfig.channelConfigs` where we must 
remember to add the relevant configs (which is error-prone).

Is there a reason why the `configure` methods can't accept an `AbstractConfig` 
instead of `Map<String, ?>`?

> Fix kafka ssl configs to not throw warnings
> -------------------------------------------
>
>                 Key: KAFKA-2472
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2472
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Sriharsha Chintalapani
>            Assignee: Ismael Juma
>             Fix For: 0.9.0.0
>
>
> This is a follow-up fix on kafka-1690.
> [2015-08-25 18:20:48,236] WARN The configuration ssl.truststore.password = 
> striker was supplied but isn't a known config. 
> (org.apache.kafka.clients.producer.ProducerConfig)
> [2015-08-25 18:20:48,236] WARN The configuration security.protocol = SSL was 
> supplied but isn't a known config. 
> (org.apache.kafka.clients.producer.ProducerConfig)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to