[ 
https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969092#comment-14969092
 ] 

ASF GitHub Bot commented on KAFKA-2338:
---------------------------------------

GitHub user benstopford opened a pull request:

    https://github.com/apache/kafka/pull/351

    KAFKA-2338: add force option to topic / config command so they can be 
called programatically

    Tiny change to add a force option to the topic and config commands so they 
can be called programatically without requiring user input. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benstopford/kafka CPKAFKA-61B

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #351
    
----
commit b29316e7174f21a91043d7a3aa451b6345324dd2
Author: Ben Stopford <benstopf...@gmail.com>
Date:   2015-10-22T12:27:13Z

    KAFKA-2338: add 'force' option to avoid console prompts

----


> Warn users if they change max.message.bytes that they also need to update 
> broker and consumer settings
> ------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-2338
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2338
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.2.1
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ben Stopford
>            Priority: Critical
>             Fix For: 0.9.0.0
>
>         Attachments: KAFKA-2338.patch, KAFKA-2338_2015-07-18_00:37:31.patch, 
> KAFKA-2338_2015-07-21_13:21:19.patch, KAFKA-2338_2015-08-24_14:32:38.patch, 
> KAFKA-2338_2015-09-02_19:27:17.patch
>
>
> We already have KAFKA-1756 filed to more completely address this issue, but 
> it is waiting for some other major changes to configs to completely protect 
> users from this problem.
> This JIRA should address the low hanging fruit to at least warn users of the 
> potential problems. Currently the only warning is in our documentation.
> 1. Generate a warning in the kafka-topics.sh tool when they change this 
> setting on a topic to be larger than the default. This needs to be very 
> obvious in the output.
> 2. Currently, the broker's replica fetcher isn't logging any useful error 
> messages when replication can't succeed because a message size is too large. 
> Logging an error here would allow users that get into a bad state to find out 
> why it is happening more easily. (Consumers should already be logging a 
> useful error message.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to