[
https://issues.apache.org/jira/browse/KAFKA-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985750#comment-14985750
]
Ashish K Singh commented on KAFKA-2716:
---------------------------------------
[~ijuma], [~gwenshap] I agree that not breaking existing usage could have been
a reason for keeping Log4jAppender dependency in core. However, do you guys
think that we can not change that even while moving to 0.9.0? The prime reason
we moved Log4jAppender out of core was that users should not have to depend on
core just to be able to use Log4jAppender. However, it seems counter-intuitive
to me that we want to make people not to depend on core got Log4jAppender and
still continue to make it possible to depend on core for just Log4jAppender. I
suggest we remove Log4jAppender dependency from core. If we choose to do so,
next concern would be why was log4j-appender system tests were failing when
Log4jAppender was removed from core's dependency. I was able to figure out the
reason. We need to add {{log4j-appender}} to tools dependency, as
VerifiableLog4jAppender uses it. I have verified that we do not need
Log4jAppender's dependency in core to be able to make system tests work. I will
submit a PR shortly, feel free to try and review it.
> Make Kafka core not depend on log4j-appender
> --------------------------------------------
>
> Key: KAFKA-2716
> URL: https://issues.apache.org/jira/browse/KAFKA-2716
> Project: Kafka
> Issue Type: Bug
> Reporter: Ashish K Singh
> Assignee: Ashish K Singh
>
> Investigate why core needs to depend on log4j-appender. AFAIK, there is no
> real dependency, however it the dependency is removed, tests won't build it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
