[ 
https://issues.apache.org/jira/browse/KAFKA-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996085#comment-14996085
 ] 

ASF GitHub Bot commented on KAFKA-2776:
---------------------------------------

GitHub user ewencp opened a pull request:

    https://github.com/apache/kafka/pull/458

    KAFKA-2776: Fix lookup of schema conversion cache size in JsonConverter.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ewencp/kafka 
kafka-2776-json-converter-cache-config-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/458.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #458
    
----
commit df6737df9e662683540eb44ff3f573298ea88763
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date:   2015-11-09T04:05:25Z

    KAFKA-2776: Fix lookup of schema conversion cache size in JsonConverter.

----


> JsonConverter uses wrong key to look up schema conversion cache size 
> configuration
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-2776
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2776
>             Project: Kafka
>          Issue Type: Bug
>          Components: copycat
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.9.0.0
>
>
> There's a typo where the wrong variable is used as the key when looking up 
> this config. Instead of SCHEMAS_CACHE_CONFIG, we have 
> SCHEMAS_CACHE_SIZE_DEFAULT. We should a) fix the naming of 
> SCHEMAS_CACHE_CONFIG to SCHEMAS_CACHE_SIZE_CONFIG and b) fix the key used 
> when looking up that configuration options. The current code results in 
> always using the default cache size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to