[ 
https://issues.apache.org/jira/browse/KAFKA-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996495#comment-14996495
 ] 

ASF GitHub Bot commented on KAFKA-2779:
---------------------------------------

GitHub user rajinisivaram opened a pull request:

    https://github.com/apache/kafka/pull/460

    KAFKA-2779: Close SSL socket channel on remote connection close

    Close socket channel in finally block to avoid file descriptor leak when 
remote end closes the connection

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-2779

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #460
    
----
commit c1ddae064d38f2cda09c1aa0475c142a0937f3f3
Author: Rajini Sivaram <[email protected]>
Date:   2015-11-09T13:04:03Z

    KAFKA-2779: Close SSL socket channel on remote connection close to avoid 
file descriptor leak

----


> Kafka SSL transport layer leaks file descriptors
> ------------------------------------------------
>
>                 Key: KAFKA-2779
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2779
>             Project: Kafka
>          Issue Type: Bug
>          Components: network
>    Affects Versions: 0.9.0.0
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>            Priority: Critical
>
> There is currently no transition from read() to close() in SslTransportLayer 
> to handle graceful shutdown requests. As a result, Kafka SSL connections are 
> never shutdown gracefully. In addition to this, close() does not handle 
> ungraceful termination of connections correctly. If flush() fails because the 
> other end has performed a close (eg. because graceful termination was not 
> handled), Kafka prints out a warning and does not close the socket. This 
> leaks file descriptors.
> We are seeing a large number of open file descriptors because our health 
> checks to Kafka result in connections that are neither terminated gracefully 
> nor closed correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to