[ 
https://issues.apache.org/jira/browse/KAFKA-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036447#comment-15036447
 ] 

ASF GitHub Bot commented on KAFKA-2929:
---------------------------------------

GitHub user granthenke opened a pull request:

    https://github.com/apache/kafka/pull/616

    KAFKA-2929: Remove duplicate error mapping functionality

    Removes ErrorMapping.scala in core in favor or Errors.java in common. 
    Duplicated exceptions in core are removed as well, to ensure the mapping is 
correct.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granthenke/kafka error-mapping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #616
    
----
commit 10003b33140144f5bd97ba37654e8396db724d92
Author: Grant Henke <granthe...@gmail.com>
Date:   2015-12-02T16:04:59Z

    KAFKA-2929: Remove duplicate error mapping functionality

----


> Remove duplicate error mapping functionality
> --------------------------------------------
>
>                 Key: KAFKA-2929
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2929
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.0
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>
> Kafka common and core both have a class that maps error codes and exceptions. 
> To prevent errors and issues with consistency we should remove 
> ErrorMapping.scala in core in favor or Errors.java in common. Any duplicated 
> exceptions in core should be removed as well to ensure the mapping is correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to