[
https://issues.apache.org/jira/browse/KAFKA-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081217#comment-15081217
]
ASF GitHub Bot commented on KAFKA-3052:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/725
KAFKA-3052; Broker properties get logged twice if acl enabled
Fix it by making it possible to pass the `doLog` parameter to
`AbstractConfig`. As explained in the code comments, this means that we can
continue to benefit from ZK default settings as specified in `KafkaConfig`
without having to duplicate code.
Also:
* Removed unused private methods from `KafkaConfig`
* Removed `case` modifier from `KafkaConfig` so that `hashCode`, `equals`
and `toString` from `AbstractConfig` are used.
* Made `props` a `val` and added `apply` method to `KafkaConfig` to
remain binary compatible.
* Call authorizer.close even if an exception is thrown during `configure`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-3052-broker-properties-get-logged-twice-if-acl-enabled
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #725
----
commit 7f2b2ec9a9f333bdbb042c68338d5f437c1df5af
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-01-04T14:27:20Z
Fix duplicate logging of broker properties when ACL is enabled
Also:
* Removed unused private methods from `KafkaConfig`
* Removed `case` modifier so that `hashCode`, `equals`
and `toString` from `AbstractConfig` are used.
* Made `props` a `val` and added `apply` method to
remain binary compatible.
commit c4f3ab3013a79ca22a3bda954d54b1226c094220
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-01-04T14:34:53Z
Call authorizer close even if an exception is thrown during `configure`
----
> broker properties get logged twice if acl is enabled
> ----------------------------------------------------
>
> Key: KAFKA-3052
> URL: https://issues.apache.org/jira/browse/KAFKA-3052
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0.0
> Reporter: Jun Rao
> Assignee: Ismael Juma
> Labels: newbie, security
> Fix For: 0.9.0.1
>
>
> This is because in SimpleAclAuthorizer.configure(), there is the following
> statement which triggers the logging of all broker properties.
> val kafkaConfig = KafkaConfig.fromProps(props)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
