[ 
https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112481#comment-15112481
 ] 

Jiangjie Qin commented on KAFKA-2066:
-------------------------------------

[~dajac] I think it would be better if you can hold back writing the patch 
until KIP-31 and KIP-32 get checked in. Otherwise either you or me need to do a 
big rebase and that's going to be a waste of time. Another reason is that after 
KIP-31 and KIP-32 get checked in, changes needed for Records, MemoryRecords and 
FileRecords(to be added) will be very clear because we simply need to make them 
equivalent to MessageSet, ByteBufferMessageSet and FileMessageSet. 

If you really want to start writing the patch now,  I would suggest you to take 
a look at PR#764 to get some ideas about what is needed for (1) and (2).

In terms of (1) we don't need to update the old producer and consumer to use 
Records.


> Replace FetchRequest / FetchResponse with their 
> org.apache.kafka.common.requests equivalents
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-2066
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2066
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Gwen Shapira
>            Assignee: David Jacot
>
> Replace FetchRequest / FetchResponse with their 
> org.apache.kafka.common.requests equivalents.
> Note that they can't be completely removed until we deprecate the 
> SimpleConsumer API (and it will require very careful patchwork for the places 
> where core modules actually use the SimpleConsumer API).
> This also requires a solution on how to stream from memory-mapped files 
> (similar to what existing code does with FileMessageSet. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to