[ 
https://issues.apache.org/jira/browse/KAFKA-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125984#comment-15125984
 ] 

Ismael Juma commented on KAFKA-3086:
------------------------------------

[~gwenshap], you said the following in the PR when I asked the compatibility 
question:

"The custom handler does not exist in 0.8.2, so this will only affect users who 
implemented it on 0.9.0.

I would prefer to remove it now (with an upgrade note). Those who use it will 
understand, since they must have noticed this method is never called."

https://github.com/apache/kafka/pull/758#issuecomment-171099641

And indeed, an upgrade note is included (although this was only committed to 
trunk in the end, so we should move the note to reflect that if it's what we 
want):

https://github.com/apache/kafka/pull/758/files

> unused handle method in MirrorMakerMessageHandler
> -------------------------------------------------
>
>                 Key: KAFKA-3086
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3086
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.0
>            Reporter: Jun Rao
>            Assignee: Jakub Nowak
>              Labels: newbie
>             Fix For: 0.9.1.0
>
>
> The following method is never used by MirrorMaker.
>   trait MirrorMakerMessageHandler {
>     def handle(record: MessageAndMetadata[Array[Byte], Array[Byte]]): 
> util.List[ProducerRecord[Array[Byte], Array[Byte]]]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to