[
https://issues.apache.org/jira/browse/KAFKA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129946#comment-15129946
]
Lee Hanxue commented on KAFKA-1801:
-----------------------------------
Removing the {{kafka.logs.dir}} variable definition does not make sense. It
will break build for kafka 0.9.0.0.
There are 5 instances of {{${kafka.logs.dir}}} in the {{log4j.properties}}
file. This variable is now undefined. Either add in the definition again, or
remove all references to {{kafka.logs.dir}} in the {{log4j.properties}} file.
I don't see why there is a need to remove any custom variables even though
there are system defined properties. Users can use system defined properties to
set their preferred value, but let's keep a sane default ?
> Remove non-functional variable definition in log4j.properties
> -------------------------------------------------------------
>
> Key: KAFKA-1801
> URL: https://issues.apache.org/jira/browse/KAFKA-1801
> Project: Kafka
> Issue Type: Improvement
> Components: log
> Affects Versions: 0.8.2.0
> Reporter: Raman Gupta
> Assignee: Raman Gupta
> Priority: Trivial
> Labels: easyfix, patch
> Fix For: 0.9.0.0
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> In log4j.properties, a property kafka.logs.dir is defined. However, modifying
> this property has no effect because log4j will always use the system property
> defined in kafka-run-class.sh before using the locally defined property in
> log4j.properties. Therefore, its probably less confusing to simply remove
> this property from here.
> See
> http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PropertyConfigurator.html
> for the property search order (system property first, locally defined
> property second).
> An alternative solution: remove the system property from kafka-run-class.sh
> and keep the one here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
