[ 
https://issues.apache.org/jira/browse/KAFKA-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141544#comment-15141544
 ] 

Gwen Shapira commented on KAFKA-3225:
-------------------------------------

Good catch. This is a bit embarrassing... we didn't have a connector that 
committed its own offsets until now (rather than relying on KafkaConnect's 
commit). 

Are you planning on supplying a patch for this? If so, I can assign you the 
JIRA.

> Method commit() of class SourceTask never invoked
> -------------------------------------------------
>
>                 Key: KAFKA-3225
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3225
>             Project: Kafka
>          Issue Type: Bug
>          Components: copycat
>    Affects Versions: 0.9.0.0
>         Environment: Windows 8.1
>            Reporter: Krzysztof Dębski
>            Assignee: Ewen Cheslack-Postava
>
> In the class org.apache.kafka.connect.source.SourceTask there is the 
> following method:
> {code}    /**
>      * <p>
>      * Commit the offsets, up to the offsets that have been returned by 
> {@link #poll()}. This
>      * method should block until the commit is complete.
>      * </p>
>      * <p>
>      * SourceTasks are not required to implement this functionality; Kafka 
> Connect will record offsets
>      * automatically. This hook is provided for systems that also need to 
> store offsets internally
>      * in their own system.
>      * </p>
>      */
>     public void commit() throws InterruptedException {
>         // This space intentionally left blank.
>     }{code}
> I have created my task which inherits from SourceTask and overrides commit(). 
> In spites of offsets being recorded automatically be Kafka, method commit() 
> is never invoked.
> I have downloaded sources of Kafka and imported them to Intelij Idea.
> Then I used "Find Usages" command. Idea found only one usage - in comments of 
> method stop().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to