[ 
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155719#comment-15155719
 ] 

ASF GitHub Bot commented on KAFKA-3255:
---------------------------------------

GitHub user frankscholten opened a pull request:

    https://github.com/apache/kafka/pull/941

    KAFKA-3255 Added unit tests for NetworkClient.connectionDelay(Node node, 
long now)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/frankscholten/kafka 
tests/cluster-connection-states

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #941
    
----

----


> Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-3255
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3255
>             Project: Kafka
>          Issue Type: Test
>          Components: core
>    Affects Versions: 0.9.0.1
>            Reporter: Frank Scholten
>            Priority: Trivial
>              Labels: test
>             Fix For: 0.9.1.0
>
>         Attachments: KAFKA-3255.patch
>
>
> I am exploring the Kafka codebase and noticed that this method was not 
> covered so I added some tests. Also saw that the method isConnecting is not 
> used anywhere in the code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to