[ https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157728#comment-15157728 ]
Guozhang Wang commented on KAFKA-2970: -------------------------------------- I merged in the patch of KAFKA-2757 which actually get rid of the classes not being aware it is intentional. Personally I feel we do not need to use two separate classes but can use the o.a.k.common.Endpoint class given that we are confident (at least for now) these fields will not change in the future, or they will always change together if they will ever change. But we should get back to this issue when this assumption is broken. [~ijuma] thoughts? > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class > ----------------------------------------------------------------------------------- > > Key: KAFKA-2970 > URL: https://issues.apache.org/jira/browse/KAFKA-2970 > Project: Kafka > Issue Type: Improvement > Components: clients > Affects Versions: 0.9.0.0 > Reporter: Grant Henke > Assignee: chen zhu > > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class which contain the same information. These should be consolidated for > simplicity and inter-opt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)