[ 
https://issues.apache.org/jira/browse/KAFKA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166721#comment-15166721
 ] 

ASF GitHub Bot commented on KAFKA-3257:
---------------------------------------

GitHub user zhuchen1018 opened a pull request:

    https://github.com/apache/kafka/pull/969

    KAFKA-3257: disable bootstrap-test-env.sh --colour option

    @becketqin, when you get a chance, could you take a look at the patch? 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhuchen1018/kafka KAFKA-3257

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #969
    
----
commit 00d99e751e938c82dd9791de74a00634e2f35418
Author: zhuchen1018 <amandazhu19620...@gmail.com>
Date:   2016-02-25T04:35:06Z

    KAFKA-3257: disable bootstrap-test-env.sh --colour option

----


> bootstrap-test-env.sh version check fails when grep has --colour option 
> enabled.
> --------------------------------------------------------------------------------
>
>                 Key: KAFKA-3257
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3257
>             Project: Kafka
>          Issue Type: Bug
>          Components: system tests
>    Affects Versions: 0.9.0.1
>            Reporter: Jiangjie Qin
>            Assignee: chen zhu
>              Labels: newbie++
>             Fix For: 0.10.0.0
>
>
> When checking the versions, we use the following command:
> {code}
> vagrant --version | egrep -o "[0-9]+\.[0-9]+\.[0-9]+"
> {code}
> This does not work if user box has --colour option enabled. In my case it 
> complains:
> Found Vagrant version 1.8.1. Please upgrade to 1.6.4 or higher (see 
> http://www.vagrantup.com for details)
> We should change this line to:
> {code}
> vagrant --version | egrep --colour=never -o "[0-9]+\.[0-9]+\.[0-9]+"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to