[ 
https://issues.apache.org/jira/browse/KAFKA-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190031#comment-15190031
 ] 

ASF GitHub Bot commented on KAFKA-3373:
---------------------------------------

GitHub user becketqin opened a pull request:

    https://github.com/apache/kafka/pull/1049

    KAFKA-3373 add 'log' prefix to configurations in KIP-31/32

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/becketqin/kafka KAFKA-3373

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1049
    
----
commit ff4a509902a888563a1dc39fd129eba7f0c53bb9
Author: Jiangjie Qin <becket....@gmail.com>
Date:   2016-03-10T21:57:46Z

    KAFKA-3373 add 'log' prefix to configurations in KIP-31/32

----


> Add `log` prefix to KIP-31/32 configs
> -------------------------------------
>
>                 Key: KAFKA-3373
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3373
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ismael Juma
>            Assignee: Jiangjie Qin
>            Priority: Blocker
>             Fix For: 0.10.0.0
>
>
> [~jjkoshy] suggested that we should prefix the configs introduced as part of 
> KIP-31/32 to include a `log` prefix:
> message.format.version
> message.timestamp.type
> message.timestamp.difference.max.ms
> If we do it, we must update the KIP.
> Marking it as blocker because we should decide either way before 0.10.0.0.
> Discussion here:
> https://github.com/apache/kafka/pull/907#issuecomment-193950768



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to