[
https://issues.apache.org/jira/browse/KAFKA-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199509#comment-15199509
]
ASF GitHub Bot commented on KAFKA-3414:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1088
KAFKA-3414; Return of MetadataCache.getAliveBrokers should not be mutated
by cache updates
`Map.values` returns `DefaultValuesIterable` where the default
implementation of `toSeq` is (sadly) `toStream`. `Stream` is a lazy collection
and it can reflect changes to the underlying map before it's `forced`.
I verified that the test failed before my change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-3414-get-alive-brokers-no-mutation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1088
----
commit 00a36ab3d6be92f3cb8c6457ee26f8b64dfcde96
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-03-17T12:39:02Z
Return of MetadataCache.getAliveBrokers should not be mutated by cache
updates
----
> Return of MetadataCache.getAliveBrokers should not be mutated by cache updates
> ------------------------------------------------------------------------------
>
> Key: KAFKA-3414
> URL: https://issues.apache.org/jira/browse/KAFKA-3414
> Project: Kafka
> Issue Type: Bug
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Priority: Critical
> Fix For: 0.10.0.0
>
>
> This is a regression from the recent work on optimising `MetadataCache`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
