[ 
https://issues.apache.org/jira/browse/KAFKA-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209863#comment-15209863
 ] 

Ewen Cheslack-Postava commented on KAFKA-3445:
----------------------------------------------

[~Ryan P] Not nit picky at all, this is actually a pretty significant 
oversight! Patch looks trivial, but could you contribute via PR according to 
the contributor guidelines: 
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes ? 
This will make it easy for me to commit the patch.

> ConnectorConfig should validate TASKS_MAX_CONFIG's lower bound limit 
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-3445
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3445
>             Project: Kafka
>          Issue Type: Improvement
>          Components: config
>            Reporter: Ryan P
>            Priority: Trivial
>              Labels: newbie
>         Attachments: KAFKA-3445.patch
>
>
> I'll be the first to admit this is a bit nit picky any property marked with 
> Importance.HIGH should be guarded against nonsensical values. 
> With that said I would like to suggest that TASKS_MAX_CONFIG be validating 
> against a lower bound limit of 1. 
> I do understand this is unlikely to happen and the configuration is 
> nonsensical but there is no penalty for stopping someone from trying it out. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to