[
https://issues.apache.org/jira/browse/KAFKA-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222826#comment-15222826
]
ASF GitHub Bot commented on KAFKA-3495:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1177
KAFKA-3495; `NetworkClient.blockingSendAndReceive` should rely on
requestTimeout
Also removed the code for handling negative timeouts in `blockingReady` as
`Selector.poll` has not supported that for a while.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-3495-blocking-send-and-receive-request-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1177
----
commit 6f215be9cb5a16a6e3149629c0c6ee2d28a9175d
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-04-02T09:57:05Z
`NetworkClient.blockingSendAndReceive` should rely on `requestTimeout`
Also removed the code for handling negative timeouts in `blockingReady`
as `Selector.poll` has not supported that for a while.
commit 51fc143c52735d93e6e6bcf2bf920845afb9682b
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-04-02T09:57:23Z
Fix typo in `NetworkClient` javadoc
----
> `NetworkClient.blockingSendAndReceive` should rely on requestTimeout
> --------------------------------------------------------------------
>
> Key: KAFKA-3495
> URL: https://issues.apache.org/jira/browse/KAFKA-3495
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 0.10.0.0
>
>
> `NetworkClient.blockingSendAndReceive` method should rely on requestTimeout
> instead of having its own timeout logic. Currently, we sometimes get an
> exception via the requestTimeout logic and other times we get it via the
> `blockingSendAndReceive` timeout logic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
