[
https://issues.apache.org/jira/browse/KAFKA-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227248#comment-15227248
]
ASF GitHub Bot commented on KAFKA-3505:
---------------------------------------
GitHub user guozhangwang opened a pull request:
https://github.com/apache/kafka/pull/1190
KAFKA-3505: Fix punctuate generated record metadata
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guozhangwang/kafka K3505
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1190
----
commit a8cf941427a9c445945ccecf68775941bc2f5a17
Author: Guozhang Wang <[email protected]>
Date: 2016-04-05T04:28:28Z
use record timestamp for punctuate, and use sentinels instead of exceptions
for punctuate
commit 469754817de9c7979026e8d2273a41c554130f27
Author: Guozhang Wang <[email protected]>
Date: 2016-04-05T18:28:41Z
fix one checkstyle failure
commit 7b7b07eb0e648d9fb96b09243057f2716f9d8abf
Author: Guozhang Wang <[email protected]>
Date: 2016-04-05T22:10:11Z
add unit tests
commit 0d556838004cde49a9f3b490608483f2a2f6f384
Author: Guozhang Wang <[email protected]>
Date: 2016-04-05T22:20:37Z
minor fixes on unit tests
----
> Set curRecord in punctuate() functions
> --------------------------------------
>
> Key: KAFKA-3505
> URL: https://issues.apache.org/jira/browse/KAFKA-3505
> Project: Kafka
> Issue Type: Sub-task
> Components: kafka streams
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Fix For: 0.10.0.0
>
>
> Punctuate() function in processor and transformer needs to be handled a bit
> differently from process(), since it can generate new records to pass through
> the topology from anywhere of the topology, whereas for the latter case a
> record is always polled from Kafka and passed via the source processors.
> Today because we do not set the curRecord correctly, calls to timestamp() /
> topic() / etc would actually trigger a KafkaStreamsException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
