Great job Jiangjie. A few comments:
1. "if an offset index entry is inserted, it will also insert a time index entry" what is the motivation for co-inserting offset index and timestamp index? Is it just for simplicity or are there any other considerations? 2. "Search message by timestamp": you may want to describe the behavior from the handling of the offset request as well, i.e. giving the timestamp returns an offset where messages before this offset are guaranteed to have smaller timestamps. Guozhang On Wed, Apr 6, 2016 at 5:44 PM, Becket Qin <becket....@gmail.com> wrote: > Hi all, > > I updated KIP-33 based on the initial implementation. Per discussion on > yesterday's KIP hangout, I would like to initiate the new vote thread for > KIP-33. > > The KIP wiki: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-33+-+Add+a+time+based+log+index > > Here is a brief summary of the KIP: > 1. We propose to add a time index for each log segment. > 2. The time indices are going to be used of log retention, log rolling and > message search by timestamp. > > There was an old voting thread which has some discussions on this KIP. The > mail thread link is following: > > http://mail-archives.apache.org/mod_mbox/kafka-dev/201602.mbox/%3ccabtagwgoebukyapfpchmycjk2tepq3ngtuwnhtr2tjvsnc8...@mail.gmail.com%3E > > I have the following WIP patch for reference. It needs a few more unit > tests and documentation. Other than that it should run fine. > > https://github.com/becketqin/kafka/commit/712357a3fbf1423e05f9eed7d2fed5b6fe6c37b7 > > Thanks, > > Jiangjie (Becket) Qin > -- -- Guozhang
