[ 
https://issues.apache.org/jira/browse/KAFKA-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232835#comment-15232835
 ] 

ASF GitHub Bot commented on KAFKA-3470:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/1206

    KAFKA-3470: treat commits as member heartbeats

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-3470

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1206
    
----
commit dd0b5054a0fa22247a72e5f7586b1121cc8751c0
Author: Jason Gustafson <ja...@confluent.io>
Date:   2016-04-08T20:06:09Z

    KAFKA-3470: treat commits as member heartbeats

----


> Consumer group coordinator should take commit requests as effective as 
> heartbeats
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-3470
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3470
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Zaiming Shi
>            Assignee: Jason Gustafson
>
> Group coordinator does not reset heartbeat timer when commit request is 
> received.
> This may lead to unnecessary session timeouts when a consumer sends
> sync commit requests so frequently that causes heartbeat requests to be
> delayed.
> Presumably (as I do not know Kafka code well):
> Commit requests (v1 and v2) have all data fields for a heartbeat request,
> If they are taken as effective as heartbeat requests, we should have
> better group stability.
> [For reference]
> previous discussions in: us...@kafka.apache.org
> mail title:   consumer group, why commit requests are not considered as 
> effective heartbeats?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to