[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242882#comment-15242882 ]
ASF GitHub Bot commented on KAFKA-3525: --------------------------------------- GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/1224 KAFKA-3525; getSequenceId should return 1 for first path creation You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/kafka KAFKA-3525 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1224.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1224 ---- commit 83143d07bc2bafdd4699b8144f55b9f44d528e0f Author: Manikumar reddy O <manikumar.re...@gmail.com> Date: 2016-04-15T12:19:53Z KAFKA-3525; getSequenceId should return 1 for first path creation ---- > max.reserved.broker.id off-by-one error > --------------------------------------- > > Key: KAFKA-3525 > URL: https://issues.apache.org/jira/browse/KAFKA-3525 > Project: Kafka > Issue Type: Bug > Components: config > Reporter: Alan Braithwaite > Assignee: Manikumar Reddy > Priority: Blocker > Fix For: 0.10.0.0 > > > There's an off-by-one error in the config check / id generation for > max.reserved.broker.id setting. The auto-generation will generate > max.reserved.broker.id as the initial broker id as it's currently written. > Not sure what the consequences of this are if there's already a broker with > that id as I didn't test that behavior. > This can return 0 + max.reserved.broker.id: > https://github.com/apache/kafka/blob/8dbd688b1617968329087317fa6bde8b8df0392e/core/src/main/scala/kafka/utils/ZkUtils.scala#L213-L215 > However, this does a <= check, which is inclusive of max.reserved.broker.id: > https://github.com/apache/kafka/blob/8dbd688b1617968329087317fa6bde8b8df0392e/core/src/main/scala/kafka/server/KafkaConfig.scala#L984-L986 -- This message was sent by Atlassian JIRA (v6.3.4#6332)