[
https://issues.apache.org/jira/browse/KAFKA-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264925#comment-15264925
]
ASF GitHub Bot commented on KAFKA-3581:
---------------------------------------
GitHub user granders opened a pull request:
https://github.com/apache/kafka/pull/1297
KAFKA-3581: add timeouts to joins in background thread services
This actually removes joins altogether, as well as references to
self.worker_threads, which is best left as an implementation detail in
BackgroundThreadService.
This makes use of @hachikuji 's recent ducktape patch, and updates ducktape
dependency to 0.5.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/confluentinc/kafka
KAFKA-3581-systest-add-join-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1297
----
commit a9108e8867afa44bdecbe760d47deccab0b94975
Author: Geoff Anderson <ge...@confluent.io>
Date: 2016-04-29T22:54:07Z
Removed expicit references to worker_threads, and added wait_node with
timeouts
----
> Use timeout when joining threads in system test services
> --------------------------------------------------------
>
> Key: KAFKA-3581
> URL: https://issues.apache.org/jira/browse/KAFKA-3581
> Project: Kafka
> Issue Type: Bug
> Components: system tests
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
>
> We have several instances in our system test services where we invoke
> Thread.join() in the stop_node() function to stop the service. It probably
> makes sense to use a timeout in join() to ensure that the process eventually
> has a chance to do unclean shutdown when the process becomes unresponsive. We
> have seen several cases in our daily runs (with the verifiable consumer in
> particular) where the process seems to hang on this join.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
