[ 
https://issues.apache.org/jira/browse/KAFKA-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297877#comment-15297877
 ] 

ASF GitHub Bot commented on KAFKA-3747:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1418


> Close `RecordBatch.records` when append to batch fails
> ------------------------------------------------------
>
>                 Key: KAFKA-3747
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3747
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.10.0.1
>
>
> We should close the existing `RecordBatch.records` when we create a new 
> `RecordBatch` for the `TopicPartition`.
> This would mean that we would only retain temporary resources like 
> compression stream buffers for one `RecordBatch` per partition, which can 
> have a significant impact when producers are dealing with slow brokers, see 
> KAFKA-3704 for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to