[
https://issues.apache.org/jira/browse/KAFKA-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316292#comment-15316292
]
ASF GitHub Bot commented on KAFKA-3771:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1451
> Improving Kafka code
> --------------------
>
> Key: KAFKA-3771
> URL: https://issues.apache.org/jira/browse/KAFKA-3771
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.10.0.0
> Reporter: Rekha Joshi
> Assignee: Rekha Joshi
> Fix For: 0.10.1.0
>
>
> Improve Kafka core code :
> Remove redundant val modifier for case class constructor
> Use flatMap instead of map and flatten
> Use isEmpty, NonEmpty, isDefined as appropriate
> Use head, keys and keySet where appropriate
> Use contains, diff and find where appropriate
> toString has no parameters, no side effect hence without () use consistently
> Remove unnecessary return and semi colons, parentheses
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
