Ismael, Jun, Thank you both for the feedback. Have updated the KIP to add dynamic default quotas for client-id with deprecation of existing static default properties.
On Wed, Jun 22, 2016 at 12:50 AM, Jun Rao <j...@confluent.io> wrote: > Yes, for consistency, perhaps we can allow client-id quota to be configured > dynamically too and mark the static config in the broker as deprecated. If > both are set, the dynamic one wins. > > Thanks, > > Jun > > On Tue, Jun 21, 2016 at 3:56 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > On Tue, Jun 21, 2016 at 12:50 PM, Rajini Sivaram < > > rajinisiva...@googlemail.com> wrote: > > > > > It is actually quite tempting to do the same for client-id quotas as > > well, > > > but I suppose we can't break existing users who have configured > defaults > > in > > > server.properties and providing two ways of setting client-id defaults > > > would be just too confusing. > > > > > > > Using two different approaches for client-id versus user quota defaults > is > > also not great. We could deprecate the server.properties default configs > > for client-id quotas and remove them in the future. In the meantime, we > > would have to live with 2 level defaults. > > > > Jun, what are your thoughts on this? > > > > Ismael > > > -- Regards, Rajini
