[
https://issues.apache.org/jira/browse/KAFKA-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349914#comment-15349914
]
ASF GitHub Bot commented on KAFKA-3842:
---------------------------------------
GitHub user bbejeck opened a pull request:
https://github.com/apache/kafka/pull/1554
MINOR: Follow-up from KAFKA-3842 with suggested fixes to creating tem…
…p directories, waitForCondition
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbejeck/kafka follow_up_for_KAFKA-3842
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1554
----
commit 48336f953a8f93a705aa756aa0b95ef356599ee0
Author: bbejeck <[email protected]>
Date: 2016-06-26T01:24:08Z
MINOR: Follow-up from KAFKA-3842 with suggested fixes to creating temp
directories, waitForCondition
----
> Add Helper Functions Into TestUtils
> -----------------------------------
>
> Key: KAFKA-3842
> URL: https://issues.apache.org/jira/browse/KAFKA-3842
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.10.1.0
> Reporter: Bill Bejeck
> Assignee: Bill Bejeck
> Fix For: 0.10.1.0
>
>
> Per guidance from [~guozhang] from PR #1477 move helper functions from
> RegexSourceIntegrationTest (getProducerConfig, getConsumerConfig,
> getStreamsConfig into TestUtils and parameterize as appropriate. Also look
> into adding a {{waitUntil(Condition condition)}} type construct to wait for a
> condition to be met without relying on using Thread.sleep
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
