[
https://issues.apache.org/jira/browse/KAFKA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369420#comment-15369420
]
ASF GitHub Bot commented on KAFKA-3887:
---------------------------------------
GitHub user guozhangwang opened a pull request:
https://github.com/apache/kafka/pull/1604
KAFKA-3887 Follow-up: add unit test for null checking in KTable aggregates
Also made a pass over the streams unit tests, with the following changes:
1. Removed three integration tests as they are already covered by other
integration tests.
2. Merged `KGroupedTableImplTest` into `KTableAggregateTest`.
3. Use mocks whenever possible to reduce code duplicates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guozhangwang/kafka
Kminor-unit-tests-consolidation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1604
----
commit c08d252e591cae875b9c43e81f38e078a025f46a
Author: Guozhang Wang <wangg...@gmail.com>
Date: 2016-07-10T05:03:50Z
make a pass over unit tests
----
> StreamBounceTest.test_bounce and StreamSmokeTest.test_streams failing
> ---------------------------------------------------------------------
>
> Key: KAFKA-3887
> URL: https://issues.apache.org/jira/browse/KAFKA-3887
> Project: Kafka
> Issue Type: Bug
> Components: streams, system tests
> Reporter: Ismael Juma
> Assignee: Guozhang Wang
> Labels: transient-system-test-failure
> Fix For: 0.10.0.1
>
>
> StreamBounceTest.test_bounce and StreamSmokeTest.test_streams has been
> failing semi-regularly. Output from the latest failure:
> {code}
> --------------------------------------------------------------------------------
> test_id:
> 2016-06-20--001.kafkatest.tests.streams.streams_bounce_test.StreamsBounceTest.test_bounce
> status: FAIL
> run time: 4 minutes 13.916 seconds
> Streams Smoke Test process on ubuntu@worker5 took too long to exit
> Traceback (most recent call last):
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.5.1-py2.7.egg/ducktape/tests/runner.py",
> line 106, in run_all_tests
> data = self.run_single_test()
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.5.1-py2.7.egg/ducktape/tests/runner.py",
> line 162, in run_single_test
> return self.current_test_context.function(self.current_test)
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/tests/kafkatest/tests/streams/streams_bounce_test.py",
> line 67, in test_bounce
> self.driver.wait()
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/tests/kafkatest/services/streams.py",
> line 94, in wait
> wait_until(lambda: not node.account.alive(pid), timeout_sec=120,
> err_msg="Streams Smoke Test process on " + str(node.account) + " took too
> long to exit")
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.5.1-py2.7.egg/ducktape/utils/util.py",
> line 36, in wait_until
> raise TimeoutError(err_msg)
> TimeoutError: Streams Smoke Test process on ubuntu@worker5 took too long to
> exit
> --------------------------------------------------------------------------------
> test_id:
> 2016-06-20--001.kafkatest.tests.streams.streams_smoke_test.StreamsSmokeTest.test_streams
> status: FAIL
> run time: 4 minutes 36.426 seconds
> Streams Smoke Test process on ubuntu@worker9 took too long to exit
> Traceback (most recent call last):
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.5.1-py2.7.egg/ducktape/tests/runner.py",
> line 106, in run_all_tests
> data = self.run_single_test()
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.5.1-py2.7.egg/ducktape/tests/runner.py",
> line 162, in run_single_test
> return self.current_test_context.function(self.current_test)
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/tests/kafkatest/tests/streams/streams_smoke_test.py",
> line 67, in test_streams
> self.driver.wait()
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/tests/kafkatest/services/streams.py",
> line 94, in wait
> wait_until(lambda: not node.account.alive(pid), timeout_sec=120,
> err_msg="Streams Smoke Test process on " + str(node.account) + " took too
> long to exit")
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.5.1-py2.7.egg/ducktape/utils/util.py",
> line 36, in wait_until
> raise TimeoutError(err_msg)
> TimeoutError: Streams Smoke Test process on ubuntu@worker9 took too long to
> exit
> {code}
> https://jenkins.confluent.io/job/system-test-kafka/255/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
