GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1643
KAFKA-3915; Don't convert messages from v0 to v1 during log compaction
The conversion is unsafe as the converted message size may be greater
than the message size limit. Updated `LogCleanerIntegrationTest` to test
the max message size case for both V0 and the current version.
Also include a few minor clean-ups:
* Remove unused expression
* Avoid unintentional usage of `scala.collection.immutable.Stream` (`toSeq`
on an `Iterator`)
* Add explicit result type in `FileMessageSet.iterator`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-3915-log-cleaner-io-buffers-message-conversion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1643
----
commit 083029d12a12ca0e750dddf08a4ce8f4ec5db8bb
Author: Ismael Juma <[email protected]>
Date: 2016-07-20T13:34:04Z
Don't convert messages from version 0 to version 1 during log compaction
The conversion is unsafe as the converted message size may be greater
than the message size limit.
commit 1262c2f87f6dd65c8624dde7f3406de7ab00cb99
Author: Ismael Juma <[email protected]>
Date: 2016-07-20T13:35:47Z
Remove unused expression, avoid usage of scala.Stream and use explicit
return type for public method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
