[ 
https://issues.apache.org/jira/browse/KAFKA-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408276#comment-15408276
 ] 

Bill Bejeck commented on KAFKA-3989:
------------------------------------

Yes, the classpath entry is in the 'buildscript section.

To me, the advantage of the shadow plugin is simplicity, as key to working with 
JMH is just building the jar file to run the benchmarks.  Seemed to me like 
some of the features in jmh-gradle aren't really needed. 

I am adding a task so you can run a single benchmark from the command line (an 
approach I'm borrowing from the JMH examples), as that's how I envision most 
people using the module.  Maybe that's an incorrect assumption on my part.

Having said that, I'm not commited to a particular solution so I can put in 
jmh-gradle if desired,     

> Add JMH module for Benchmarks
> -----------------------------
>
>                 Key: KAFKA-3989
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3989
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Bill Bejeck
>            Assignee: Bill Bejeck
>             Fix For: 0.10.1.0
>
>
> JMH is a Java harness for building, running, and analyzing benchmarks written 
> in Java or JVM languages.  To run properly JMH needs to be in it's own 
> module.   This task will also investigate using the jmh -gradle pluging 
> [https://github.com/melix/jmh-gradle-plugin] which enables the use of JMH 
> from gradle.  This is related to 
> [https://issues.apache.org/jira/browse/KAFKA-3973]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to