[
https://issues.apache.org/jira/browse/KAFKA-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411868#comment-15411868
]
ASF GitHub Bot commented on KAFKA-3936:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/1711
KAFKA-3936: Validate parameters as early as possible
Added non null checks to parameters supplied via the DSL and
`TopologyBuilder`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-3936
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1711.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1711
----
commit c7a672e8959e957cc40d1c7c9c1443b3301308d2
Author: Damian Guy <[email protected]>
Date: 2016-08-08T14:12:53Z
validate params in DSL and TopologyBuilder
----
> Validate user parameters as early as possible
> ---------------------------------------------
>
> Key: KAFKA-3936
> URL: https://issues.apache.org/jira/browse/KAFKA-3936
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Damian Guy
> Priority: Minor
> Labels: beginner, newbie, starter
>
> Currently, parameters handed in by the user via public API, are not
> validated. For example {{stream.to(null)}} would fail when the underlying
> producer gets instantiated. This result in a stack trace from deep down in
> the library, making it hard to reason about the problem for the user.
> We want to check all given user parameters as early as possible and raise
> corresponding (and helpful!) exceptions to explain users what the problem is,
> and how to fix it. All parameter checks should get unit tested.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
