[ 
https://issues.apache.org/jira/browse/KAFKA-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469156#comment-15469156
 ] 

ASF GitHub Bot commented on KAFKA-4033:
---------------------------------------

GitHub user vahidhashemian reopened a pull request:

    https://github.com/apache/kafka/pull/1726

    KAFKA-4033: KIP-70: Revise Partition Assignment Semantics on New Consumer's 
Subscription Change

    This PR changes topic subscription semantics so a change in subscription 
does not immediately cause a rebalance.
    Instead, the next poll or the next scheduled metadata refresh will update 
the assigned partitions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-4033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1726
    
----
commit 09d35a5f8b5b91c9d71de345c14ccf8c8ef21876
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-22T18:45:52Z

    KAFKA-4033: KIP-70: Revise Partition Assignment Semantics on New Consumer's 
Subscription Change
    
    This PR changes topic subscription semantics so a change in subscription 
does not immediately cause a rebalance.
    Instead, the next poll or the next scheduled metadata refresh will update 
the assigned partitions.

commit e26a42fff83ea8a3d997ad97d5cc2b5704f1e62b
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-22T23:29:48Z

    Unit test for subscription change

commit cc9c4c4750addbc7a99588ff69e669b96a18d361
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-24T06:22:05Z

    Clean up KafkaConsumerTest.java and add reusable methods

commit f60fb52a702a6bcb854e9560548174fc5ad86730
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-26T00:23:22Z

    Fix unsubscribe semantics and update unit tests

----


> KIP-70: Revise Partition Assignment Semantics on New Consumer's Subscription 
> Change
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-4033
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4033
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Vahid Hashemian
>            Assignee: Vahid Hashemian
>
> Modify the new consumer's implementation of topics subscribe and unsubscribe 
> interfaces so that they do not cause an immediate assignment update (this is 
> how the regex subscribe interface is implemented). Instead, the assignment 
> remains valid until it has been revoked in the next rebalance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to