[
https://issues.apache.org/jira/browse/KAFKA-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491880#comment-15491880
]
ASF GitHub Bot commented on KAFKA-4172:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/1857
KAFKA-4172: Ensure fetches responses contain the requested partitions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-4172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1857
----
commit 02aa611e3aba76bb73cee15b2706f7cf24cb6279
Author: Jason Gustafson <ja...@confluent.io>
Date: 2016-09-15T00:16:56Z
KAFKA-4172: Ensure fetches responses contain the requested partitions
----
> Fix masked test error in
> KafkaConsumerTest.testSubscriptionChangesWithAutoCommitEnabled
> ---------------------------------------------------------------------------------------
>
> Key: KAFKA-4172
> URL: https://issues.apache.org/jira/browse/KAFKA-4172
> Project: Kafka
> Issue Type: Bug
> Components: consumer, unit tests
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
> Fix For: 0.10.1.0
>
>
> This test case has an incorrectly matched mock fetch response, which was
> silently raising an NPE, which was caught in NetworkClient. In general, aside
> from fixing the test, we are probably missing a null check in the
> FetchRespose to verify that the partitions included in the fetch response
> were actually requested. This is usually not a problem because the broker
> doesn't send us invalid fetch responses, but it's probably better to be a
> little more defensive when handling responses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
