[ 
https://issues.apache.org/jira/browse/KAFKA-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525688#comment-15525688
 ] 

ASF GitHub Bot commented on KAFKA-4223:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/1917

    KAFKA-4223: RocksDBStore should close all open iterators on close

    Keep track of open Rocks DB iterators. When a store is closed, close all 
open iterators.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-4223

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1917
    
----
commit 0ac6fee500d31620bc67acb5a67953169f586717
Author: Damian Guy <damian....@gmail.com>
Date:   2016-09-27T10:16:06Z

    keep track off open rocksdb iterators. close open iterators when the store 
is closed

----


> RocksDBStore should close all open iterators on close
> -----------------------------------------------------
>
>                 Key: KAFKA-4223
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4223
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.1.0
>            Reporter: Damian Guy
>            Assignee: Damian Guy
>             Fix For: 0.10.1.0
>
>
> RocksDBStore doesn't keep track of the open iterators. So when the store is 
> closed due to rebalance or otherwise, this may result in resource leakage as 
> any open iterators will not be closed.
> The store should keep track of the open iterators and close them when the 
> store is closed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to