GitHub user gabrielreid opened a pull request:

    https://github.com/apache/kafka/pull/1948

    KAFKA-4245: Don't swallow IOExceptions

    Remove swallowing of exceptions from BlockingChannel#connect.
    
    This commit also slightly reworks the handling of a
    BlockingChannel in KafkaServer to correctly handle the possibility
    of an IOException being thrown by BlockingChannel#connect().
    
    Note that I'm totally new to Scala, so any advice on anything I might
    be doing here that is unconventional or just plain wrong is 
    certainly welcome.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gabrielreid/kafka KAFKA-4245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1948
    
----
commit 396a52b9f0bbca5fd438dd7e4dd108fc4e4ec911
Author: Gabriel Reid <gr...@apache.org>
Date:   2016-10-02T13:44:41Z

    KAFKA-4245 Don't swallow IOExceptions
    
    Remove swallowing of exceptions from BlockingChannel#connect.
    
    This commit also slightly reworks the handling of a
    BlockingChannel in KafkaServer to correctly handle the possibility
    of an IOException being thrown by BlockingChannel#connect().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to