[
https://issues.apache.org/jira/browse/KAFKA-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563996#comment-15563996
]
ASF GitHub Bot commented on KAFKA-4289:
---------------------------------------
GitHub user radai-rosenblatt opened a pull request:
https://github.com/apache/kafka/pull/2006
KAFKA-4289 - moved short-lived loggers to companion objects
Signed-off-by: radai-rosenblatt <radai.rosenbl...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radai-rosenblatt/kafka omgsrsly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2006
----
commit 7b475e6eaffab891b8737c00df71d951cc52c81b
Author: radai-rosenblatt <radai.rosenbl...@gmail.com>
Date: 2016-10-11T00:21:07Z
KAFKA-4289 - moved short-lived loggers to companion objects
Signed-off-by: radai-rosenblatt <radai.rosenbl...@gmail.com>
----
> CPU wasted on reflection calls initializing short-lived loggers
> ---------------------------------------------------------------
>
> Key: KAFKA-4289
> URL: https://issues.apache.org/jira/browse/KAFKA-4289
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.10.0.1
> Reporter: radai rosenblatt
>
> an internal profiling run at linkedin found ~5% of the CPU time consumed by
> `sun.reflect.Reflection.getCallerClass()`.
> digging into the stack trace shows its from initializing short lived logger
> objects in `FileMessageSet` and `RequestChannel.Request`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
