ASF GitHub Bot commented on KAFKA-4296:

GitHub user hachikuji opened a pull request:


    KAFKA-4296: Fix LogCleaner statistics rolling


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-4296

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2016
commit a96ad989e9d1bcc3a1a061bbf42776f0c2ad9ec3
Author: Jason Gustafson <ja...@confluent.io>
Date:   2016-10-13T00:10:43Z

    KAFKA-4296: Fix LogCleaner statistics rolling


> LogCleaner CleanerStats swap logic seems incorrect
> --------------------------------------------------
>                 Key: KAFKA-4296
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4296
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For:
> In LogCleaner, we keep track of two instances of the {{CleanerStats}} object 
> in a tuple object. One instance is intended to keep track the stats for the 
> last cycle while the other is for the current cycle. The idea is to swap them 
> after each cleaning cycle, but the current logic does not actually mutate the 
> existing tuple, which means that we always clear the same instance of 
> {{CleanerStats}} after each cleaning.

This message was sent by Atlassian JIRA

Reply via email to