ASF GitHub Bot commented on KAFKA-4298:

GitHub user hachikuji opened a pull request:


    KAFKA-4298: Ensure compressed message sets are converted when cleaning the 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-4298

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2019
commit af3b31b4d94ece1603ac470bfd8d781558987501
Author: Jason Gustafson <ja...@confluent.io>
Date:   2016-10-13T04:56:52Z

    KAFKA-4298: Ensure compressed message sets are converted when cleaning the 


> LogCleaner does not convert compressed message sets properly
> ------------------------------------------------------------
>                 Key: KAFKA-4298
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4298
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Critical
>             Fix For:
> When cleaning the log, we attempt to write the cleaned messages using the 
> message format configured for the topic, but as far as I can tell, we do not 
> convert the wrapped messages in compressed message sets. For example, if 
> there is an old compressed message set with magic=0 in the log and the topic 
> is configured for magic=1, then after cleaning, the new message set will have 
> a wrapper with magic=1, but the nested messages will still have magic=0. If 
> this happens, there does not seem to be an easy way to recover without 
> manually fixing up the log.

This message was sent by Atlassian JIRA

Reply via email to